forum.webdiplomacy.net

webDip dev coordination forum / public access todo list
It is currently Sun Sep 24, 2017 1:58 pm

All times are UTC




Post new topic Reply to topic  [ 3 posts ] 
Author Message
 Post subject: StP bug
PostPosted: Thu Oct 14, 2010 7:26 pm 
Offline

Joined: Thu Oct 14, 2010 7:24 pm
Posts: 1
So, I wanted a fleet in StP (nc) to hold, but was playing around with the options, and this was one: Fleet St Petersburg (nc) support move to Barents Sea from St Petersburg. It also let me submit it, although a single exclamation point showed up where the !! or check usually appears.


Top
 Profile  
 
 Post subject: Re: StP bug
PostPosted: Fri Jan 14, 2011 1:15 am 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
Hmm, sounds like the client-side order generation check that you're not supporting a move from the place you're supporting from doesn't take coasts into account.

Thanks for the bug report, I'll try and fix this, but it's not critical since the server-side order validation code is picking up the mistake (hence the exclamation marks)


Top
 Profile  
 
 Post subject: Re: StP bug
PostPosted: Tue Aug 06, 2013 1:11 pm 
Offline

Joined: Tue Nov 15, 2011 2:54 pm
Posts: 44
Discovered this bug today as well.

It is easy to fix as you just have to insert ".coastParent" in line 228 in model.js:

Code:
function(n){return (n==this.Territory.coastParent.id||n==AgainstTerritory.id);

instead of
Code:
function(n){return (n==this.Territory.id||n==AgainstTerritory.id);


Even this is low priority I would be happy to see it fixed in the official code soon as I use the getSupportMoveFrom()-function for the grey-out feature of the interactive map, I'm working on.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group