forum.webdiplomacy.net

webDip dev coordination forum / public access todo list
It is currently Sun May 27, 2018 9:34 am

All times are UTC




Post new topic Reply to topic  [ 6 posts ] 
Author Message
 Post subject: Bugs in 0.91 (and fixes)
PostPosted: Thu Sep 10, 2009 2:27 pm 
Offline

Joined: Wed Sep 09, 2009 2:37 pm
Posts: 156
globalAddTime in the most current website version (0.91) was missing the database query line (see below)

Code:

public function globalAddTime
(array $params)
{
    global $DB;
    $timeHours=(int)$params['timeHours'];
    if($timeHours==0)
        $set=time().' + phaseMinutes*60';    
    else
        $set
="processTime + ".$timeHours.'*60*60';

    // CCJ: I added this line vvv
    $DB->sql_put('UPDATE wD_Games SET processTime = '.$set);
    
    
// CCJ: Also changed this to English
    if($timeHours==0)
        return 'All game process times have been set to their phase time';
    else
        return 
'All games have had '.$timeHours.' hours added to them';
}
 


Top
 Profile  
 
PostPosted: Thu Sep 10, 2009 4:04 pm 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
Thanks for that, no idea how that happened.


Top
 Profile  
 
PostPosted: Thu Sep 10, 2009 4:45 pm 
Offline

Joined: Wed Sep 09, 2009 2:37 pm
Posts: 156
Also, if you have time, take a look at the re-process option. It seemed to "work" in 0.90, but it always threw an error on the next page. I haven't checked yet in 0.91 because I don't have a test game up yet.


Top
 Profile  
 
PostPosted: Thu Sep 10, 2009 5:36 pm 
Offline

Joined: Wed Sep 09, 2009 2:37 pm
Posts: 156
The banIP function in objectsUser doesn't work (including when banning a user)

Quote:
Fatal error: Using $this when not in object context in /home/careyj/careyj.com/dip4/objects/user.php on line 558


I took a quick look at it but couldn't figure it out, since I'm not the best OOP programmer. I'm running PHP version 5.2.9.


Top
 Profile  
 
PostPosted: Thu Sep 10, 2009 5:57 pm 
Offline

Joined: Wed Sep 09, 2009 2:37 pm
Posts: 156
Install.sql still has the old wD_Games table before jayp's changes (using phaseHours instead of phaseMinutes)


Top
 Profile  
 
PostPosted: Wed Sep 30, 2009 10:06 pm 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
I'll fix install.sql when I release 0.92, and the banIP bug should be sorted out now, thanks for letting me know about these


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group