forum.webdiplomacy.net

webDip dev coordination forum / public access todo list
It is currently Sun Nov 19, 2017 5:43 pm

All times are UTC




Post new topic Reply to topic  [ 6 posts ] 
Author Message
PostPosted: Thu Apr 22, 2010 7:58 pm 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Hi I tried to check for some special commands in board/orders/diplomacy.php, but most functions are private, so they can't be changes from variants.
Could you change them to "private"?

Thanks,
Oliver


Top
 Profile  
 
PostPosted: Fri Apr 23, 2010 8:24 pm 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Don't want to hurry, but it would be nice, if you could include this in your next version.
Looks like I finally got the river rule of the imperium variant working. But it needs to change the userOrderDiplomacy class...

Oliver


Top
 Profile  
 
PostPosted: Sat Apr 24, 2010 4:12 am 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
I've changed the board/* files to use protected rather than private fields for now, in the latest code tarball. To be honest this is somewhat bad practice, but I should be able to do a better job of it in a future version


Top
 Profile  
 
PostPosted: Sat Apr 24, 2010 5:25 am 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Whow, that was fast.
It's currently not in the tarball, but I don't mind waiting for 1.0 on sourceforge.
Just got gilgatex code working with the variant-system, now I'll try to solve that without rewriting each adjucation-class....

Oliver


Top
 Profile  
 
PostPosted: Sat Apr 24, 2010 11:59 am 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Now it's in. Thanks.
BTW: You might consider adding the UnitDestroyIndex-patch too...

Oliver


Top
 Profile  
 
PostPosted: Sat Apr 24, 2010 12:47 pm 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
Must have missed that one, I'll have a look for it when I get a chance


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group