forum.webdiplomacy.net

webDip dev coordination forum / public access todo list
It is currently Sun Nov 19, 2017 5:42 pm

All times are UTC




Post new topic Reply to topic  [ 7 posts ] 
Author Message
PostPosted: Thu Apr 01, 2010 9:16 pm 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Is there a reason this is commented out (in gamemaster/game.php)?
It's a really useful information that should be displayed in the info-bar.

Oliver


Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 3:20 am 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
I think it is displayed, but only if it's a WTA game


Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 4:06 am 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
Currently it's not displayed at all. You commented it out.

Code:
      $leftBottom = '<div class="titleBarLeftSide">
            Pot: <span class="gamePot">'.$this->pot.' '.libHTML::points().'</span>';
   //      <span class="gamePotType" title="'.$this->potType.'">('.($this->potType=='Points-per-supply-center'?'PPSC':'WTA').')</span>';


Oliver


Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 6:27 am 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
Ah right that's the home page gamepanel. Since that'd only be for games you're already joined in, and it can get pretty tight on space and people were complaining about it being too cluttered, having the pot type seemed redundant

The idea of the home page gamepanels is just to give you notifications about changes in your games at a glance, and places a lesser importance on giving you full info about the game


Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 9:51 am 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
That code was not from the home page gameboard, but from the code for the header of the gamepanel (the one with the map and the orders to enter) and the search results...

Oliver


Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 2:38 pm 
Offline
Site Admin

Joined: Sat Jun 28, 2008 6:24 am
Posts: 892
I haven't checked to see exactly which functions render the gamelistings and board page title segments, but from a check on my server it does seem to be rendering them correctly

I've attached a couple of screen clips, let me know if I'm looking in the wrong area


Attachments:
File comment: Board page
2.png
2.png [ 14.34 KiB | Viewed 464 times ]
File comment: Game listings
1.png
1.png [ 82.8 KiB | Viewed 463 times ]
Top
 Profile  
 
PostPosted: Fri Apr 02, 2010 4:00 pm 
Offline

Joined: Wed Jul 29, 2009 10:22 am
Posts: 841
I'm just blind. You are right.
Sorry.

Oliver


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group